Param regression bug fix#18
Merged
paulvarkey merged 16 commits intolf-connectivity:mainfrom May 1, 2025
Merged
Conversation
Mobility model Param Regression and all code Black Formatter
black format all the code (#16)
FahimSadikRashad
pushed a commit
to FahimSadikRashad/maveric
that referenced
this pull request
Oct 28, 2025
* [v0.2]: SinrDB Bug Fix (lf-connectivity#25) Co-authored-by: Lkishor123 <[email protected]> * Traffic Demand Generation Suite (lf-connectivity#20) * Fixed PR changes for params_regression * Fixed Unittest for param_regression according to PR change * Fixed the mobility notebook and radp_library file(PR changes done) * Resolved test_param_regression unittest cases * Updated Param Regression and radp library as instructed in the PR review * Changed the scipy dependency to solve dependency error * Changed how seed value works especially made it user friendly * Refactored functions and changed the imports * Resolved test_param_regression imports * All Black Changes * MRO (lf-connectivity#17) (lf-connectivity#7) * Fixed PR changes for params_regression * Fixed Unittest for param_regression according to PR change * Fixed the mobility notebook and radp_library file(PR changes done) * Resolved test_param_regression unittest cases * Updated Param Regression and radp library as instructed in the PR review * Changed the scipy dependency to solve dependency error * Changed how seed value works especially made it user friendly * Refactored functions and changed the imports * Resolved test_param_regression imports * All Black Changes * Added MRO code and test cases * Modified requirements-dev.txt to include dotnev * Changed the directory for mro from radp/digital_twin to apps * Changed MRO app code according to main API design * added _format_ue_data_and_topology method * Refactored some MRO app code and moved helper codes to radp_library * fixed mro_app and updated test * fixed minor issue in mro_app * added some of the test methods * fixed naming issue * updated minor issue * added most test cases * added test for training and prediction * removed redundent code and comments * Changed solve function and removed redundant codes * Fixed recent CI issue for MRO Test cases * Fixed bugs for MRO app * MRO unittest bug fix * Bug fix for MRO dataframe columns * Refined MRO app with SimpleMRO and MRO_Using_RL implementations * Fixed perform_attacchment unittest error * MRO Final PR Fix (lf-connectivity#5) * added testcases for updated cell_selection * blacked and moved rxpower function * Added mro_test notebook to test the mro app * solve issue found * Refactored the example notebook for MRO * Debugging Tanzim's workflow * added notebook sequence * rxpwr bypass init * f1, f0 done * added all preprocess funcs * minor fix * got dict * update * update * fixed dict data * cleaned nb * added docstrings * minor fix * completed training from scratch * added the solve bug fix * added todo and fixed rl * update * fixed col constraint issue & missing cell info issue * fixed dtype mismatch * added new update bdt logic * added old mro in parallel to new * fixed jitter issue * minor type hint fixes * added update() docstring * formatted no rxpwr simpleMRO nb * added _update() * added save and load bdt save and load tested in nb added save and load; tested * enabled cuda and flexibility for rl, fixed simple print for simple, removed redundent code for jitter * reapplied covarience * updated tests * refactored predictions * temp mro & mro pr-fix nb updated * get rid of unused func and tests * mro_pr-fix nb updated for sanity check * addded cartesian check and nb * addded cartesian nb heading updated * moved norm_cells cartesian_check add_cell_info to radp_lib * mro nb skeleton updated * final mro nb with mro_data.zip, gitignore nb/req.txt updated * added tests for mro * added radp library tests * removed debugging nbs * tests done, rebased & epochs reset * added mro readme at root --------- * MRO PR-fix Changes (lf-connectivity#6) * added testcases for updated cell_selection * blacked and moved rxpower function * Added mro_test notebook to test the mro app * solve issue found * Refactored the example notebook for MRO * Debugging Tanzim's workflow * added notebook sequence * rxpwr bypass init * f1, f0 done * added all preprocess funcs * minor fix * got dict * update * update * fixed dict data * cleaned nb * added docstrings * minor fix * completed training from scratch * added the solve bug fix * added todo and fixed rl * update * fixed col constraint issue & missing cell info issue * fixed dtype mismatch * added new update bdt logic * added old mro in parallel to new * fixed jitter issue * minor type hint fixes * added update() docstring * formatted no rxpwr simpleMRO nb * added _update() * added save and load bdt save and load tested in nb added save and load; tested * enabled cuda and flexibility for rl, fixed simple print for simple, removed redundent code for jitter * reapplied covarience * updated tests * refactored predictions * temp mro & mro pr-fix nb updated * get rid of unused func and tests * mro_pr-fix nb updated for sanity check * addded cartesian check and nb * addded cartesian nb heading updated * moved norm_cells cartesian_check add_cell_info to radp_lib * mro nb skeleton updated * final mro nb with mro_data.zip, gitignore nb/req.txt updated * added tests for mro * added radp library tests * removed debugging nbs * tests done, rebased & epochs reset * added mro readme at root * update mr nb removing no rxpwr flow * added plots * Added typecasting and docstrings to radp_library.py * final sanity checked for cosmetics changes * fixed simple & rl mro constructor * fixed mro typehints * safe delete mro nb & zip * re added mro nb & zip * added plotly req * fixed dict to Dict type --------- --------- Co-authored-by: Menon Pranto <[email protected]> Co-authored-by: Ahnaf Tanjid <[email protected]> Co-authored-by: RafidUl-Karim <[email protected]> Co-authored-by: Ahnaf19 <ahnaftanjid19@@google.com> * [Traffic_Demand_Generation]: Inital Commit, contains placeholders for all functions as per release plan. * Fixes: 1. Removed cell_txpwr_dbm from topology.csv config gen. 2. Fixed (create_dummy_params_if_missing flag) for spatial_params.json and time_params.json not working. * Added UT: test_traffic_demand_simulation, covers: 1. Input Validation & Edge Cases 2. Core Logic & Output Structur 3. Dependency Handling & Fallbacks 4. Orchestration 5. Specific Algorithm Behaviors * [Traffic Load Gen]: Refactored Code * Refactored: v0.3.1: Traffic Load * updated TL dirs in tests --------- Co-authored-by: Menon Pranto <[email protected]> Co-authored-by: Ahnaf Tanjid <[email protected]> Co-authored-by: RafidUl-Karim <[email protected]> Co-authored-by: Ahnaf19 <ahnaftanjid19@@google.com> Co-authored-by: Lkishor123 <[email protected]> * v0.3.2: Energy Saving App (lf-connectivity#24) * Energy Saving App * energy reward updated with cco & reward sum bugfix Signed-off-by: Ahnaf19 <[email protected]> * added demo & updated visualization Signed-off-by: WaterMenon <[email protected]> * fixed import bug Signed-off-by: WaterMenon <[email protected]> * cleaned & renamed to energy savings Signed-off-by: Ahnaf19 <[email protected]> renamed to energy savings Signed-off-by: Ahnaf19 <[email protected]> * disabled legacy tests --------- Signed-off-by: Ahnaf19 <[email protected]> Signed-off-by: WaterMenon <[email protected]> Co-authored-by: Ahnaf19 <[email protected]> Co-authored-by: WaterMenon <[email protected]> * v0.3.3: Load Balance App (lf-connectivity#22) * Load Balance App * added demo & convex hull visuals * Fixed PR changes for params_regression * Fixed Unittest for param_regression according to PR change * Fixed the mobility notebook and radp_library file(PR changes done) * Resolved test_param_regression unittest cases * Updated Param Regression and radp library as instructed in the PR review * Changed the scipy dependency to solve dependency error * Changed how seed value works especially made it user friendly * Refactored functions and changed the imports * Resolved test_param_regression imports * All Black Changes * MRO (lf-connectivity#17) (lf-connectivity#7) * Fixed PR changes for params_regression * Fixed Unittest for param_regression according to PR change * Fixed the mobility notebook and radp_library file(PR changes done) * Resolved test_param_regression unittest cases * Updated Param Regression and radp library as instructed in the PR review * Changed the scipy dependency to solve dependency error * Changed how seed value works especially made it user friendly * Refactored functions and changed the imports * Resolved test_param_regression imports * All Black Changes * Added MRO code and test cases * Modified requirements-dev.txt to include dotnev * Changed the directory for mro from radp/digital_twin to apps * Changed MRO app code according to main API design * added _format_ue_data_and_topology method * Refactored some MRO app code and moved helper codes to radp_library * fixed mro_app and updated test * fixed minor issue in mro_app * added some of the test methods * fixed naming issue * updated minor issue * added most test cases * added test for training and prediction * removed redundent code and comments * Changed solve function and removed redundant codes * Fixed recent CI issue for MRO Test cases * Fixed bugs for MRO app * MRO unittest bug fix * Bug fix for MRO dataframe columns * Refined MRO app with SimpleMRO and MRO_Using_RL implementations * Fixed perform_attacchment unittest error * MRO Final PR Fix (lf-connectivity#5) * added testcases for updated cell_selection * blacked and moved rxpower function * Added mro_test notebook to test the mro app * solve issue found * Refactored the example notebook for MRO * Debugging Tanzim's workflow * added notebook sequence * rxpwr bypass init * f1, f0 done * added all preprocess funcs * minor fix * got dict * update * update * fixed dict data * cleaned nb * added docstrings * minor fix * completed training from scratch * added the solve bug fix * added todo and fixed rl * update * fixed col constraint issue & missing cell info issue * fixed dtype mismatch * added new update bdt logic * added old mro in parallel to new * fixed jitter issue * minor type hint fixes * added update() docstring * formatted no rxpwr simpleMRO nb * added _update() * added save and load bdt save and load tested in nb added save and load; tested * enabled cuda and flexibility for rl, fixed simple print for simple, removed redundent code for jitter * reapplied covarience * updated tests * refactored predictions * temp mro & mro pr-fix nb updated * get rid of unused func and tests * mro_pr-fix nb updated for sanity check * addded cartesian check and nb * addded cartesian nb heading updated * moved norm_cells cartesian_check add_cell_info to radp_lib * mro nb skeleton updated * final mro nb with mro_data.zip, gitignore nb/req.txt updated * added tests for mro * added radp library tests * removed debugging nbs * tests done, rebased & epochs reset * added mro readme at root --------- * MRO PR-fix Changes (lf-connectivity#6) * added testcases for updated cell_selection * blacked and moved rxpower function * Added mro_test notebook to test the mro app * solve issue found * Refactored the example notebook for MRO * Debugging Tanzim's workflow * added notebook sequence * rxpwr bypass init * f1, f0 done * added all preprocess funcs * minor fix * got dict * update * update * fixed dict data * cleaned nb * added docstrings * minor fix * completed training from scratch * added the solve bug fix * added todo and fixed rl * update * fixed col constraint issue & missing cell info issue * fixed dtype mismatch * added new update bdt logic * added old mro in parallel to new * fixed jitter issue * minor type hint fixes * added update() docstring * formatted no rxpwr simpleMRO nb * added _update() * added save and load bdt save and load tested in nb added save and load; tested * enabled cuda and flexibility for rl, fixed simple print for simple, removed redundent code for jitter * reapplied covarience * updated tests * refactored predictions * temp mro & mro pr-fix nb updated * get rid of unused func and tests * mro_pr-fix nb updated for sanity check * addded cartesian check and nb * addded cartesian nb heading updated * moved norm_cells cartesian_check add_cell_info to radp_lib * mro nb skeleton updated * final mro nb with mro_data.zip, gitignore nb/req.txt updated * added tests for mro * added radp library tests * removed debugging nbs * tests done, rebased & epochs reset * added mro readme at root * update mr nb removing no rxpwr flow * added plots * Added typecasting and docstrings to radp_library.py * final sanity checked for cosmetics changes * fixed simple & rl mro constructor * fixed mro typehints * safe delete mro nb & zip * re added mro nb & zip * added plotly req * fixed dict to Dict type --------- --------- Co-authored-by: Menon Pranto <[email protected]> Co-authored-by: Ahnaf Tanjid <[email protected]> Co-authored-by: RafidUl-Karim <[email protected]> Co-authored-by: Ahnaf19 <ahnaftanjid19@@google.com> * Completed load balance demo nb * completed demo * updated ue visuals * convex hull visuals implemented --------- Co-authored-by: tanzim10 <[email protected]> Co-authored-by: Tanzim Farhan <[email protected]> Co-authored-by: Ahnaf Tanjid <[email protected]> Co-authored-by: RafidUl-Karim <[email protected]> Co-authored-by: Ahnaf19 <ahnaftanjid19@@google.com> * updated timesteps * renamed load_balancing_app >> load_balancing * renamed load_balance >> load_balancing * minor fix fixed a naming convention in notebook * reward updated with cco score * added logs data agents --------- Co-authored-by: Lkishor123 <[email protected]> Co-authored-by: WaterMenon09 <[email protected]> Co-authored-by: Ahnaf Tanjid <[email protected]> Co-authored-by: RafidUl-Karim <[email protected]> Co-authored-by: Ahnaf19 <ahnaftanjid19@@google.com> Co-authored-by: WaterMenon <[email protected]> --------- Signed-off-by: Ahnaf19 <[email protected]> Signed-off-by: WaterMenon <[email protected]> Co-authored-by: WaterMenon09 <[email protected]> Co-authored-by: Lkishor123 <[email protected]> Co-authored-by: Menon Pranto <[email protected]> Co-authored-by: Ahnaf Tanjid <[email protected]> Co-authored-by: RafidUl-Karim <[email protected]> Co-authored-by: Ahnaf19 <ahnaftanjid19@@google.com> Co-authored-by: L Kishor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the distance calculation method in the param_regression.py file, replacing the get_log_distance function with distance.
Key Changes:
Distance Calculation Update:
File Updated: